[PATCH] D73339: [RISCV] Compress instructions based on function features

[Luís Marques via Phabricator via llvm-commits]

luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/CodeGen/RISCV/compress-float.ll:2
+; This test is designed to run three times, once with function attributes, once
+; with all target attributes added on the command line, and one with compress
+; added with the command line and float added via function attributes, all
----------------
Nitpick: one -> once


================
Comment at: llvm/test/CodeGen/RISCV/compress-float.ll:34
+
+define float @float_load(float *%a) nounwind #0 {
+; RV32IFDC-LABEL: float_load:
----------------
You're adding nounwind twice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73339/new/

https://reviews.llvm.org/D73339