[PATCH] D75175: [CallSiteInfo] Enable the call site info only for -g + optimizations

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 09:06:47 PST 2020


djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: llvm/include/llvm/Target/TargetOptions.h:266
     unsigned EnableDebugEntryValues : 1;
+    /// NOTE: There are targets that still do not support the call site info
+    /// production (the info about the arguments passed to the call, necessary
----------------
dstenb wrote:
> What do you think about keeping these as two separate things, and query one of EmitCallSiteInfo / EnableDebugEntryValues at each use? I think that it might make it easier to understand the code if they are treated as separate throughout the compiler rather than being merged here.
It is good idea actually! thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75175/new/

https://reviews.llvm.org/D75175





More information about the llvm-commits mailing list