[PATCH] D75266: SROA: Don't drop atomic load/store alignments (PR45010)

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet requested changes to this revision.
gchatelet added a comment.
This revision now requires changes to proceed.

Thank you for taking a look @hans !
Only two nits on my side.



================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:2523
+      if (NewLI->isAtomic())
+        NewLI->setAlignment(MaybeAlign(LI.getAlignment()));
 
----------------
`NewLI->setAlignment(LI.getAlign());`


================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:2715
+    if (NewSI->isAtomic())
+      NewSI->setAlignment(MaybeAlign(SI.getAlignment()));
     Pass.DeadInsts.insert(&SI);
----------------
`NewSI->setAlignment(SI.getAlign());`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75266/new/

https://reviews.llvm.org/D75266