[PATCH] D74904: [CallSiteInfo] Handle bundles when updating call site info

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 08:49:59 PST 2020


aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/BranchFolding.cpp:173
   std::for_each(MBB->begin(), MBB->end(), [MF](const MachineInstr &MI) {
-    if (MI.isCandidateForCallSiteEntry())
+    if (MI.shouldUpdateCallSiteInfo())
       MF->eraseCallSiteInfo(&MI);
----------------
drive-by comment: Should there be a 

```
MachineInstruction::eraseStaleCallSiteInfo() {
  if (shouldUpdateCallSiteInfo())
    getFunction()->eraseCallSiteInfo(&MI);
}
```

helper?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74904/new/

https://reviews.llvm.org/D74904





More information about the llvm-commits mailing list