[PATCH] D75216: [lld][ELF] Add some release notes

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 08:06:22 PST 2020


MaskRay added inline comments.


================
Comment at: lld/docs/ReleaseNotes.rst:39
-
-* Reduced size of linked MIPS binaries.
 
----------------
atanasyan wrote:
> MaskRay wrote:
> > atanasyan wrote:
> > > Why did you remove this line?
> > IIUC, you meant https://reviews.llvm.org/rL371554.
> > 
> > But this size optimization is generic. It also removes upto 3*maxpagesize for other targets.
> > 
> > For example, defaultMaxPageSize is also 65536 on AArch64/powerpc32/powerpc64.
> I agree that this change is generic. Does it make a sense to mention about it in the release notes in a generic form?
It is covered by the `-z noseparate-code` item below.


================
Comment at: lld/docs/ReleaseNotes.rst:73
+  (`D73474 <https://reviews.llvm.org/D73474>`_)
+* The quality of PowerPC32 port has been greatly improved (canonical PLT, copy
+  relocations, non-preemptible IFUNC, range extension thunks with addends).
----------------
psmith wrote:
> Insert 
> * The ARM port will no longer interwork via changing a BL to a BLX for non STT_FUNC symbols. A warning will be given if this results in a change from previous LLD releases.
> (`D73542 <https://reviews.llvm.org/D73542`_)
D73542 is not in the `release/10.x` branch.

@psmith I think it makes sense to cherry pick https://reviews.llvm.org/rG29c13615576b80129c8167df1d77f1ce98a97ae7 to release/10.x . Is that your intention?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75216/new/

https://reviews.llvm.org/D75216





More information about the llvm-commits mailing list