[PATCH] D75057: Syndicate, test and fix base64 implementation

Thu Feb 27 08:02:12 PST 2020

hokein added a comment.

thanks for doing this! didn't look into details yet. Could you explain what was the bug in the previous code? since this patch contains some refactoring changes, it is not quite straightforward to spot it.

================
Comment at: llvm/unittests/Support/Base64Test.cpp:1
+//===- llvm/unittest/Support/Base64.cpp - Base64 tests --------------------===//
+//
----------------
nit: Base64Test.cpp.

================
Comment at: llvm/unittests/Support/Base64Test.cpp:30
+  // from: https://tools.ietf.org/html/rfc4648#section-10
+  TestBase64("", "");
+  TestBase64("f", "Zg==");
----------------
nit: i would just inline the `TestBase64`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75057/new/

https://reviews.llvm.org/D75057