[PATCH] D75217: [mlir] NFC - Move runner utils from mlir-cpu-runner to tools

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache marked an inline comment as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/tools/mlir-runner-utils/CMakeLists.txt:6
+add_llvm_library(mlir-runner-utils SHARED mlir-runner-utils.cpp)
+target_compile_definitions(mlir-runner-utils PRIVATE mlir-runner-utils_EXPORTS)
----------------
mehdi_amini wrote:
> The `tools` directory isn't usually for exposing "libraries" but for exposing command line... tools?
> 
> Will this trigger the installation of a `mlir-runner-utils` library for example?
ok, I am working on changes to move that under ExecutionEngine.
I need to split things that need a C++ runtime from others for mobile anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75217/new/

https://reviews.llvm.org/D75217