[PATCH] D75247: [mlir] fix wrong symbol order in AffineApplyNormalizer

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 06:01:28 PST 2020


nicolasvasilache added a comment.

Well actually the example you added is `affine.min(affine.apply())` and goes against what I wrote above and would ideally have been composed in the first place.

I'd recommend we start putting verifiers that disallow such chains everywhere and simplify the logic, but I have not followed deeply what new assumptions have crept inside affine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75247/new/

https://reviews.llvm.org/D75247





More information about the llvm-commits mailing list