[PATCH] D75236: [APFloat] Overload unary operator-

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 05:02:43 PST 2020


foad marked 2 inline comments as done.
foad added inline comments.


================
Comment at: llvm/unittests/ADT/APFloatTest.cpp:2992
+  EXPECT_TRUE(NegQNaN.bitwiseIsEqual(-QNaN));
+  EXPECT_TRUE(QNaN.bitwiseIsEqual(-NegQNaN));
 }
----------------
RKSimon wrote:
> Don't we need to keep the neg tests as well as adding the unary tests?
Fair enough, done, though I planned to remove APFloat::neg in a follow-up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75236/new/

https://reviews.llvm.org/D75236





More information about the llvm-commits mailing list