[PATCH] D75123: [obj2yaml, yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 02:11:29 PST 2020


jhenderson added a comment.

In D75123#1892941 <https://reviews.llvm.org/D75123#1892941>, @grimar wrote:

> 3. Using large chunk of raw bytes is a bad practice. Should we care much about keeping a shorter way to describe it?


I think this is the key question to me. We shouldn't be encouraging large binary blobs, and if we get a situation where one is needed, perhaps the test needs simplifying/converting to assembly, or obj2yaml/yaml2obj needs extending. In other words, I don't think this change is particularly useful, as blobs should be kept to very short amounts (circa 32 bytes I reckon at most).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75123/new/

https://reviews.llvm.org/D75123





More information about the llvm-commits mailing list