[PATCH] D73886: [DebugInfo] Refine the condition to detect CIEs.

Wed Feb 26 21:33:22 PST 2020

ikudrin added a comment.

In D73886#1893606 <https://reviews.llvm.org/D73886#1893606>, @probinson wrote:

> Hmmm.  I guess the next question is, do we have to bail out when something doesn't look right?  Or can we keep going?
>  If we see an FDE with no preceding CIE, yes that's something we should report, but the `not --crash` tells me we are abandoning attempts to continue dumping the section.  Does one of your other patches address this?

`DWARFDebugFrame::parse()` tends to call `report_fatal_error()` in case of any trouble; that was initially added in https://reviews.llvm.org/rG705085da37eed9557202ff1e86f9462842ef7af9 and than extended in D15535 <https://reviews.llvm.org/D15535> (https://reviews.llvm.org/rG03a670c0ec1d38de8c206de1426340041f10f8ff).

While I agree that the parser should not crash the program on invalid input, resolving that lays a bit far away from my current intentions, which are just to add support for 64-bit values here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73886/new/

https://reviews.llvm.org/D73886