[PATCH] D75203: Relax existing instructions to reduce the number of nops needed for alignment purposes

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/include/llvm/MC/MCFragment.h:278
+/// Represents alignment for either code or data.  For code, the Value and
+/// ValueSize fields are ignored; nops are always emitted.  For date, the
+/// Value is repeated ValueSize times.  Value is usually 0.
----------------
For data


================
Comment at: llvm/include/llvm/MC/MCFragment.h:279
+/// ValueSize fields are ignored; nops are always emitted.  For date, the
+/// Value is repeated ValueSize times.  Value is usually 0.
 class MCAlignFragment : public MCFragment {
----------------
"Value is repeated ValueSize times" , I am afraid this statement is not true. `ValueSize` is the size of the integer (in bytes) of `Value`, and the `Value` is repeated `FragmentSize / AF.getValueSize()` times.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75203/new/

https://reviews.llvm.org/D75203