[PATCH] D75140: [MLIR] Add LLVMConversionTarget as a customization point. NFC.

Tim Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 18:25:12 PST 2020


timshen added a comment.

In D75140#1892771 <https://reviews.llvm.org/D75140#1892771>, @mehdi_amini wrote:

> Can you provide a description for this patch which would motivate this please?


Updated the comments. It's clearer to refer to D75141 <https://reviews.llvm.org/D75141> and see that an action is added as illegal / dynamically legal. Without this centeralized place, we have to change all the users who write `addLegalDialect<LLVM::LLVMDialect>` to add the illegal action in D75141 <https://reviews.llvm.org/D75141>. This real intent is hard to put in the class comments, as it might get stale.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75140/new/

https://reviews.llvm.org/D75140





More information about the llvm-commits mailing list