[PATCH] D75218: Make asm printer for X86 use custom separator instead of hard-coded tabs.

[Ondrej Sykora via Phabricator via llvm-commits]

ondrasej resigned from this revision.
ondrasej added a comment.

I've added a couple of comments, but ultimately I can't approve the revision (don't have the approval rights).



================
Comment at: llvm/include/llvm/MC/MCInstPrinter.h:107
 
+  /// If true, the printer will uses separator set with ::setSeparator()
+  virtual bool supportCustomSeparator() { return false; }
----------------
s/uses/use/

+ Add a period at the end of the line.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp:58
       (STI.getFeatureBits()[X86::Mode64Bit])) {
-    OS << "\tcallq\t";
+    OS << Separator << "callq" << Separator;
     printPCRelImm(MI, 0, OS);
----------------
Consider allowing different sequences for indentation and as a separator between tokens. E.g. it could make sense to indent by four spaces, but it probably isn't the right choice for a separator.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75218/new/

https://reviews.llvm.org/D75218