[PATCH] D75196: [dsymutil] Avoid copying swiftinterfaces from the SDK into the dsym bundle

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 11:04:18 PST 2020


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:174
     return;
+  // Don't track interfaces that are part of the SDK.
+  StringRef SysRoot = dwarf::toStringRef(DIE.find(dwarf::DW_AT_LLVM_sysroot));
----------------
Nit: I'd add a newline before and after the new code to visually distinguish it as a single unit for the given comment. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75196/new/

https://reviews.llvm.org/D75196





More information about the llvm-commits mailing list