[PATCH] D75120: [ValueLattice] Add new state for undef constants. (WIP)

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SCCP.cpp:439
-      // Undef values remain unknown.
-      if (!isa<UndefValue>(V))
         LV.markConstant(C);          // Constants are constant
----------------
efriedma wrote:
> Not sure about this change; do we not need to markUndef?
markConstant used to be a no-op for UndefValue constants. I've updated it to use markUndefined for UndefValue constants, it might be clearer to do it explicitly here though?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75120/new/

https://reviews.llvm.org/D75120