[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

In D73242#1893506 <https://reviews.llvm.org/D73242#1893506>, @tejohnson wrote:

> In D73242#1888295 <https://reviews.llvm.org/D73242#1888295>, @tejohnson wrote:
>
> > FYI I have reproduced the failure, and am starting to debug.
>
>
> I see what is going on and have a simple fix, just need to create a test case. Expect to send a patch to fix this today, hopefully this morning.


Thanks! Let me know, I'll test right away.

I'm seeing another (new?) bug with latest trunk, I'm not sure if it's related or not. The repro is the same, just sync the latest, and do the two-stage build, then `ninja check-lld`, all the LTO tests fail with this stack:

   #0 0x00007ff63bd7e891 `anonymous namespace'::RealFile::`scalar deleting dtor'(unsigned int) (d:\llvm-project\buildninjarelmimalloc\bin\ld.lld.exe+0x1e891)
   #1 0x00007ff63c47d4ac llvm::FPPassManager::~FPPassManager D:\llvm-project\llvm\include\llvm\IR\LegacyPassManagers.h:461:0
   #2 0x00007ff63c47c98c `anonymous namespace'::MPPassManager::~MPPassManager D:\llvm-project\llvm\lib\IR\LegacyPassManager.cpp:407:0
   #3 0x00007ff63c475fac llvm::PMTopLevelManager::~PMTopLevelManager(void) D:\llvm-project\llvm\lib\IR\LegacyPassManager.cpp:855:0
   #4 0x00007ff63c47c3bc llvm::legacy::FunctionPassManagerImpl::`scalar deleting dtor'(unsigned int) D:\llvm-project\llvm\lib\IR\LegacyPassManager.cpp:324:0
   #5 0x00007ff63c39aa41 `anonymous namespace'::codegen D:\llvm-project\llvm\lib\LTO\LTOBackend.cpp:373:0
   #6 0x00007ff63c39732c llvm::lto::backend(struct llvm::lto::Config const &, class std::function<(unsigned int)>, unsigned int, class std::unique_ptr<class llvm::Module, struct std::default_delete<class llvm::Module>>, class llvm::ModuleSummaryIndex &) D:\llvm-project\llvm\lib\LTO\LTOBackend.cpp:466:0
   #7 0x00007ff63be8a49a llvm::lto::LTO::run(class std::function<(unsigned int)>, class std::function<(unsigned int, class llvm::StringRef)>) D:\llvm-project\llvm\lib\LTO\LTO.cpp:942:0
   #8 0x00007ff63c153eb5 lld::elf::BitcodeCompiler::compile(void) D:\llvm-project\lld\ELF\LTO.cpp:261:0
   #9 0x00007ff63bdc0b01 lld::elf::LinkerDriver::main D:\llvm-project\lld\ELF\Driver.cpp:522:0
  #10 0x00007ff63bdba6dc lld::elf::link(class llvm::ArrayRef<char const *>, bool, class llvm::raw_ostream &, class llvm::raw_ostream &) D:\llvm-project\lld\ELF\Driver.cpp:117:0
  #11 0x00007ff63bd61807 main D:\llvm-project\lld\tools\lld\lld.cpp:166:0
  #12 0x00007ff63e9cf914 __scrt_common_main_seh d:\agent\_work\5\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288:0
  #13 0x00007ffa95737bd4 (C:\WINDOWS\System32\KERNEL32.DLL+0x17bd4)
  #14 0x00007ffa972eced1 (C:\WINDOWS\SYSTEM32\ntdll.dll+0x6ced1)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73242/new/

https://reviews.llvm.org/D73242