[PATCH] D75187: [AMDGPU][ConstantFolding] Fold llvm.amdgcn.cube* intrinsics

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 08:51:28 PST 2020


foad marked an inline comment as done.
foad added inline comments.


================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:2310
 
+static float ConstantFoldAMDGCNCubeIntrinsic(Intrinsic::ID IntrinsicID, float S0, float S1, float S2) {
+  float ID, MA, SC, TC;
----------------
arsenm wrote:
> Using host FP operations is generally frowned on, and this should use APFloat
OK, but the APFloat API is horrible to use for anything more complicated than + - * /.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75187/new/

https://reviews.llvm.org/D75187





More information about the llvm-commits mailing list