[PATCH] D75036: [DebugInfo] Describe call site values for chains of expression producing instrs

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 08:33:00 PST 2020


dstenb added a comment.

In D75036#1892843 <https://reviews.llvm.org/D75036#1892843>, @djtodoro wrote:

> This looks good to me. Thanks!


Thanks for the review! I'm planning on landing this tomorrow unless there are any more commits.

> //(Out of the topic of this patch) // I'm thinking of the fact all this "entry-values and call-site-values" related work is getting bigger, so it might be worth of refactoring all of this in a class or a compile unit, but we can discuss about it later.

That sounds like a good idea.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75036/new/

https://reviews.llvm.org/D75036





More information about the llvm-commits mailing list