[PATCH] D75179: [AMDGPU][ConstantFolding] Fold llvm.amdgcn.fract intrinsic

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 07:55:15 PST 2020


foad marked an inline comment as done.
foad added inline comments.


================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:1797
+    if (IntrinsicID == Intrinsic::amdgcn_fract) {
+      // TODO what should amdgcn_fract return for tiny negative arguments?
+      // GLSL defines fract(x) as x - floor(x).
----------------
arsenm wrote:
> This should match the instruction behavior (although I guess we can ignore the bug on SI)
Is there a good public reference for that? The Vega ISA Reference Guide doesn't go into much detail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75179/new/

https://reviews.llvm.org/D75179





More information about the llvm-commits mailing list