[PATCH] D75104: [tools][llvm-objcopy] Enable --discard-all for MachO

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 07:35:43 PST 2020


jhenderson added a comment.

Looks good from my point of view, but I don't know enough about the Mach-O to verify the behaviour of the option.



================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp:179
       Config.StripSections || Config.StripUnneeded ||
-      Config.DiscardMode != DiscardType::None || !Config.SymbolsToAdd.empty() ||
+      Config.DiscardMode == DiscardType::Locals || !Config.SymbolsToAdd.empty() ||
       Config.EntryExpr) {
----------------
Nit: clang-format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75104/new/

https://reviews.llvm.org/D75104





More information about the llvm-commits mailing list