[PATCH] D75112: [mlir] NFC: move test/IR/core-ops.mlir to test/Dialect/StandardOps/roundtrip.mlir

Wed Feb 26 01:33:20 PST 2020

ftynse added a comment.

In D75112#1891741 <https://reviews.llvm.org/D75112#1891741>, @bondhugula wrote:

> In D75112#1891672 <https://reviews.llvm.org/D75112#1891672>, @ftynse wrote:
>
> > In D75112#1891307 <https://reviews.llvm.org/D75112#1891307>, @bondhugula wrote:
> >
> > > roundtrip.mlir seems to be a generic name; ops.mlir?
> >
> >
> > I fail to see how "ops" is any less generic than "roundtrip". This test exercises essentially parsers and printers, that's what roundtrip is about.
>
>
> Hmm... a lot of the test cases do roundtripping (all the op parse/print?) and you don't have to prefix/suffix each with roundtrip. If the test case is all about standard dialect op parsing/printing(?), I felt ops.mlir was apt.

Most tests do _rely on_ roundtripping, only specific actually _test_ it. This specific file has header comments "Verify the printed output can be parsed." and "Verify the generic form can be parsed." and is indeed concerned only with the standard dialect.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75112/new/

https://reviews.llvm.org/D75112