[PATCH] D73887: [DebugInfo] Do not truncate 64-bit values when dumping CIEs and FDEs.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

P.S. please remember to mark inline comments as "Done" using the checkbox once you address something. If you do that before uploading a patch, they will get automatically submitted when the patch is uploaded.



================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugFrameTest.cpp:21
+  dwarf::CIE TestCIE(
+      /* IsDWARF64 = */ true,
+      /* Offset = */ 0x1111abcdabcdULL,
----------------
ikudrin wrote:
> jhenderson wrote:
> > clang-format-recognised style is `/*IsDWARF64=*/true`.
> > 
> > Same principle applies throughout.
> A side note. It looks like `clang-format` recognizes both styles, and both are used in the LLVM codebase, but the condensed variant is way more widespread and also is mentioned in the LLVM Coding Standards (not as a requirement, just as an example).
When you say "recognises" I think what happens is that it treats the old style as a normal inline comment, so applies the normal comment formatting rules. That is based purely on observation though, so I could be completely wrong!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73887/new/

https://reviews.llvm.org/D73887