[PATCH] D75149: [ELF] --orphan-handling=: don't warn/error for unused synthesized sections

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/test/ELF/linkerscript/orphan-report.s:18
+
+## --strip-all discards .strtab and .symtab . Don't error about them.
+# RUN: not ld.lld --orphan-handling=error --strip-all -o /dev/null -T %t.script \
----------------
There is an excessive space after ".symtab". Pehaps just add the word "sections"?


================
Comment at: lld/test/ELF/linkerscript/orphan-report.s:37
+# SYMTAB:      <internal>:(.strtab) is being placed in '.strtab'
+# COMMON-NOT: <internal>
 
----------------
Use `--implicit-check-not=<internal>` in tests?
In the current way seems the test case accepts the situation when for a COMMON case
there is an internal section between `.comment` and `.shstrtab`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75149/new/

https://reviews.llvm.org/D75149