[PATCH] D75135: Revert "[WebAssembly] MC: Mark more function aliases as functions"

[Michael Liao via Phabricator via llvm-commits]

hliao added a comment.

In D75135#1892257 <https://reviews.llvm.org/D75135#1892257>, @sbc100 wrote:

> Sounds reasonable.  We can looking into other solutions.
>
> My understand is that the IR in question is perfectly valid, and can be compiled on other targets, can't it?  Its only WebAssembly that can't compile this.  We can't ask the producer so not produce this valid bitcode when building for WebAssembly can we?


Yeah, that IR itself is valid, but WASM has more restrictive assertions. It assumes data symbol should be referenced to data location only. As WASM is a virtual ISA, that assumption is right as all references to code fragments would be invalid except kernel entries (used in function invocation). But that's not true for other binary formats, symbols in non-function types may be offsets in code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75135/new/

https://reviews.llvm.org/D75135