[PATCH] D69891: [VP,Integer,#1] Vector-predicated integer intrinsics

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 22:07:33 PST 2020


simoll marked an inline comment as done.
simoll added inline comments.


================
Comment at: llvm/lib/IR/IntrinsicInst.cpp:276
+  auto VLConst = dyn_cast<ConstantInt>(VLParam);
+  if (VLConst && VLConst->getSExtValue() == -1)
+    return true;
----------------
andrew.w.kaylor wrote:
> Why are you doing this and not just "less than zero"?
Because with the new LangRef wording %evl is unsigned and the `i32 -1` constant is handled as a special case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69891/new/

https://reviews.llvm.org/D69891





More information about the llvm-commits mailing list