[PATCH] D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2)

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram marked 4 inline comments as done.
tmsriram added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFunction.cpp:363
+  // This should only be done once no matter how many times it is called.
+  if (this->BBSectionsSorted || !this->getBBSections())
+    return false;
----------------
efriedma wrote:
> Can this actually get called more than once?
> 
> Why do we care if the blocks are sorted?  Does it help optimize the code somehow?
Having basic blocks in the same section together makes it really easy to update CFI and DebugInfo (like label differences).  It also makes the .s more readable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73674/new/

https://reviews.llvm.org/D73674