[PATCH] D73886: [DebugInfo] Refine the condition to detect CIEs.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 16:53:34 PST 2020


ikudrin added a comment.

In D73886#1891998 <https://reviews.llvm.org/D73886#1891998>, @probinson wrote:

> The two tests look like they have an FDE with no preceding CIE?  Isn't that invalid?


The inputs are for sure invalid. The idea was to check that our consumer does not misinterpret them as valid CIEs as it did before the patch.

> Well, in one test that's on purpose, but the other one looks like it's being handled as if the input were actually valid.

We allow FDEs without CIEs in .debug_frame, for good or bad. However, that is out of the scope of this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73886/new/

https://reviews.llvm.org/D73886





More information about the llvm-commits mailing list