[PATCH] D75083: [ORC] Add SymbolState::Emitted to isInMaterializationPhase()

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 16:53:33 PST 2020


lhames added a comment.

I had a look over the users in Core.cpp and isInMaterializationPhase was actually being used inconsistently. I think it may have made sense when it was introduced, but shifted from its original intent at some point.

I have removed it in b7aa1cc3a43 <https://reviews.llvm.org/rGb7aa1cc3a43db83560edb59dcbde7bd5e03683fe> and replaced it with direct checks on the symbol state, so I think you can discard this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75083/new/

https://reviews.llvm.org/D75083





More information about the llvm-commits mailing list