[PATCH] D75146: [mlir][Linalg] NFC - Refactor LinalgStructuredOps towards "named" Linalg ops

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.h:60
+
+class ConvOp;
+/// Builds the indexing expressions for a ConvOp `op`. Returns the vector of
----------------
nit: Please move forward declarations to the top.


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td:361
+////////////////////////////////////////////////////////////////////////////////
+// Generic Linalg ops.
+////////////////////////////////////////////////////////////////////////////////
----------------
Can you please use the standardized format:
https://github.com/llvm/llvm-project/blob/b3e6487f02ac98b6c4a501f5da10c867bd98f769/mlir/lib/IR/Block.cpp#L15



================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOpsInterface.td:22
+  let methods = [
+    //========================================================================//
+    // Loop types handling.
----------------
Same here.


================
Comment at: mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:914
 
-static SmallVector<AffineExpr, 4> concat(ArrayRef<AffineExpr> a,
-                                         ArrayRef<AffineExpr> b) {
+SmallVector<AffineExpr, 4> mlir::linalg::concat(ArrayRef<AffineExpr> a,
+                                                ArrayRef<AffineExpr> b) {
----------------
Was there a problem with using llvm::concat?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75146/new/

https://reviews.llvm.org/D75146