[PATCH] D75110: Avoid dangling reference when indexing sections

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 14:45:55 PST 2020


serge-sans-paille added a comment.

In D75110#1891890 <https://reviews.llvm.org/D75110#1891890>, @lhames wrote:

> Thanks very much for this Serge!
>
> Is the std::deque fix a one-liner? This shouldn't be very performance sensitive, so I'd be inclined to go with that.


It is! Compared to this patch, which was a pleasure to write nonetheless, I'd go for the <dequeue> approach ;-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75110/new/

https://reviews.llvm.org/D75110





More information about the llvm-commits mailing list