[PATCH] D75091: [X86MCTargetDesc.h] Speculative fix for macro collision with sys/param.h

Tue Feb 25 13:53:36 PST 2020

vsk added a comment.

@teemperor the build fails in the same place with D74891 <https://reviews.llvm.org/D74891> and D74892 <https://reviews.llvm.org/D74892> applied, you can see here that '-Xclang -fmodules-local-submodule-visibility' gets picked up:

  FAILED: tools/llvm-ar/CMakeFiles/llvm-ar.dir/llvm-ar.cpp.o 
  /Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/bin/clang++  -DGTEST_HAS_RTTI=0 -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/llvm-ar -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/tools/llvm-ar -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/libxml2 -Iinclude -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include -Wdocumentation -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -fmodules -fmodules-cache-path=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/module.cache -fcxx-modules -Xclang -fmodules-local-submodule-visibility -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -O3  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk    -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/llvm-ar/CMakeFiles/llvm-ar.dir/llvm-ar.cpp.o -MF tools/llvm-ar/CMakeFiles/llvm-ar.dir/llvm-ar.cpp.o.d -o tools/llvm-ar/CMakeFiles/llvm-ar.dir/llvm-ar.cpp.o -c /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/tools/llvm-ar/llvm-ar.cpp
  /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/tools/llvm-ar/llvm-ar.cpp:177:29: error: expected identifier
  enum Format { Default, GNU, BSD, DARWIN, Unknown };
                              ^
  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/sys/param.h:72:13: note: expanded from macro 'BSD'
  #define BSD     199506          /* System version (year & month). */

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75091/new/

https://reviews.llvm.org/D75091