[PATCH] D75130: Remove BinaryOperator::CreateFNeg

[Simon Moll via Phabricator via llvm-commits]

simoll marked an inline comment as done.
simoll added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:341
     Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI);
     // TODO: Remove the hack for the binop form when the unary op is optimized
     //       properly with all IR passes.
----------------
xbolva00 wrote:
> What about this TODO?
Ok. So this seems to be a hack to update the FSub idiom on the fly.
How about we get rid of the TODO and the code below in a separate patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75130/new/

https://reviews.llvm.org/D75130