[PATCH] D74976: [CostModel][X86] Improve extract/insert element costs (PR43605)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 13:25:32 PST 2020


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:2410-2412
     unsigned Width = LT.second.getVectorNumElements();
+    unsigned SubWidth = Width;
     Index = Index % Width;
----------------
I don't really like how we are conflating vector element count and vector/element bit width,
It took me a moment to notice that `Width` is actually element count..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74976/new/

https://reviews.llvm.org/D74976





More information about the llvm-commits mailing list