[PATCH] D75065: [cmake] Strip quotes in compiler-rt/lib/crt

Zhizhou Yang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 10:46:28 PST 2020


zhizhouy added a comment.

> Wouldn't this break when compile command contains a quoted path with spaces?

As mentioned in the comment of r372312 <https://reviews.llvm.org/rGec841cf36ca1cb6a154393d7e9f48e8723a38966>,
space should not be a new issue here since in line 50 we are going to replace all spaces with ";".

  string(REPLACE " " ";" test_compile_command "${test_compile_command}")




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75065/new/

https://reviews.llvm.org/D75065





More information about the llvm-commits mailing list