[PATCH] D75094: [MachineInstr] Add a dumpr method

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nit



================
Comment at: llvm/lib/CodeGen/MachineInstr.cpp:1484
+    Register Reg = MO.getReg();
+    if (!Register::isVirtualRegister(Reg))
+      continue;
----------------
Reg.isPhysical


================
Comment at: llvm/lib/CodeGen/MachineInstr.cpp:1486-1487
+      continue;
+    const MachineInstr *NewMI;
+    if (!(NewMI = MRI.getUniqueVRegDef(Reg)))
+      continue;
----------------
I think the !( looks weird so you could juts move the assignment to the definition 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75094/new/

https://reviews.llvm.org/D75094