[PATCH] D75042: [LLD][ELF][ARM] Implement Thumb pc-relative relocations for adr and ldr

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 07:48:38 PST 2020


psmith updated this revision to Diff 246461.
psmith added a comment.

Thanks for the comments, I've removed the checks for Symbol being nullptr, these could exist if we were to call with relocateNoSym, but we don't do that at present. Removed -n and used /dev/null in all error tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75042/new/

https://reviews.llvm.org/D75042

Files:
  lld/ELF/Arch/ARM.cpp
  lld/ELF/InputSection.cpp
  lld/ELF/Relocations.h
  lld/test/ELF/arm-thumb-adr-err.s
  lld/test/ELF/arm-thumb-adr.s
  lld/test/ELF/arm-thumb-ldrlit-err.s
  lld/test/ELF/arm-thumb-ldrlit.s
  lld/test/ELF/arm-thumb-pc8-weak.s
  lld/test/ELF/arm-thumb-undefined-weak.s
  lld/test/ELF/arm-thumb2-adr-err.s
  lld/test/ELF/arm-thumb2-adr.s
  lld/test/ELF/arm-thumb2-ldrlit-err.s
  lld/test/ELF/arm-thumb2-ldrlit.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75042.246461.patch
Type: text/x-patch
Size: 22381 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200225/6001b315/attachment.bin>


More information about the llvm-commits mailing list