[PATCH] D73176: [ARM] Fix dropped dollar sign from symbols in branch targets

Lucas Prates via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 05:09:14 PST 2020


pratlucas updated this revision to Diff 246418.
pratlucas added a comment.

Removed restriction of branch instruction mnemonic for allowing $-prefixed
symbol names in operands, resolving ambriguity in favor of symbol names over
expression start.

There is currently a limitation on AsmParser's core causing  $-prefixed symbol
names composed by numeric sequences not to be accepted. This will be handled in
a separate patch.
The test case for `b $4` will be added to the separate patch accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73176/new/

https://reviews.llvm.org/D73176

Files:
  llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  llvm/test/MC/ARM/arm-branches.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73176.246418.patch
Type: text/x-patch
Size: 5680 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200225/5af2090f/attachment.bin>


More information about the llvm-commits mailing list