[PATCH] D75043: [DWARFDebugLine] Avoid dumping prologue members we did not parse

[Pavel Labath via Phabricator via llvm-commits]

labath marked 3 inline comments as done.
labath added inline comments.


================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test:44
 # FATAL:      debug_line[0x00000048]
-# FATAL-NEXT: Line table prologue
-# FATAL-NEXT: total_length: 0xfffffffe
+# RESERVED: warning: parsing line table prologue at offset 0x00000048 unsupported reserved unit length found of value 0xfffffffe
 # FATAL-NOT:  debug_line
----------------
jhenderson wrote:
> For this and the two version checks, it's probably worth adding a CHECK-NOT immediately after the warning that shows the (rest of the) prologue is not printed.
> 
> Without it, I don't think you have any test coverage for the early exit, right?
Indeed, thanks for pointing that out. I was too busy updating this test to realize that the new functionality was not actually tested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75043/new/

https://reviews.llvm.org/D75043