[PATCH] D74879: [llvm-objcopy][test] Improve empty section tests

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 01:19:20 PST 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/empty-section.test:6
 
-!ELF
+# CHECK1:      Name         Type     Address          Off    Size   ES Flg Lk Inf Al
+# CHECK1-NEXT:              NULL     0000000000000000 000000 000000 00      0   0  0
----------------
Seems to me like here and below you can get rid of the columns after `Off`?


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/empty-section.test:39
 
+## Test that we attribute .empty to the second segment. Its offset is assigned according to
+## p_offset of the second segment.
----------------
according to the


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/strip-non-alloc.test:11-12
+
+---
 !ELF
 FileHeader:
----------------
Shouldn't these two be on the same line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74879/new/

https://reviews.llvm.org/D74879





More information about the llvm-commits mailing list