[PATCH] D75092: [AMDGPU][NFC] Refactor emitEntryFunctionPrologue

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:328
 
-  // No replacement necessary.
+  unsigned ScratchWaveOffsetReg = MFI->getScratchWaveOffsetReg();
+
----------------
s/unsigned/Register


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:476
 
-  unsigned SPReg = MFI->getStackPtrOffsetReg();
-  assert(SPReg != AMDGPU::SP_REG);
-
-  // FIXME: Remove the isPhysRegUsed checks
-  const bool HasFP = hasFP(MF);
+  if (CopyBuffer && CopyBufferFirst)
+    BuildMI(MBB, I, DL, TII->get(AMDGPU::COPY), ScratchRsrcReg)
----------------
Should have braces


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:484
 
-  if (CopyBuffer && !CopyBufferFirst) {
+  if (CopyBuffer && !CopyBufferFirst)
     BuildMI(MBB, I, DL, TII->get(AMDGPU::COPY), ScratchRsrcReg)
----------------
Braces


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:489
+  // FIXME: This should also implement the setup path for HSA.
+  if (ScratchRsrcReg != AMDGPU::NoRegister)
+    emitEntryFunctionScratchRsrcRegSetup(
----------------
Braces


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:497
 
+    unsigned SPReg = MFI->getStackPtrOffsetReg();
+    assert(SPReg != AMDGPU::SP_REG);
----------------
Register


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.h:61
+                                        MachineBasicBlock::iterator I,
+                                        DebugLoc DL,
+                                        Register ScratchWaveOffsetReg) const;
----------------
Should probably be const DebugLoc&


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.h:72
+                                            MachineBasicBlock::iterator I,
+                                            DebugLoc DL,
+                                            Register PreloadedPrivateBufferReg,
----------------
Ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75092/new/

https://reviews.llvm.org/D75092