[PATCH] D74989: [LoopTerminology] Loop Simplify Form

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: llvm/docs/LoopTerminology.rst:152
+a LoopPass. This pass is implemented in
+`LoopInfo.h http://llvm.org/doxygen/LoopSimplify_8h_source.html`_.
+When it is successful, the loop has:
----------------
baziotis wrote:
> This is an external link. I don't know if this is ok.
It's a link to the doxygen-generated reference, not the link that @fhahn suggested. (I don't mind keeping the doxygen link)

Documentation for cross-references (preferable within Sphinx) is [[ https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#ref-role | here ]].



================
Comment at: llvm/include/llvm/Transforms/Utils/LoopSimplify.h:11-12
 // simpler form, which makes subsequent analyses and transformations simpler and
-// more effective.
+// more effective. A summary of this pass is documented in
+// https://llvm.org/docs/LoopTerminology.html#loop-simplify-form
 //
----------------
baziotis wrote:
> Instead of putting a link, we could just put the info that this file is missing because it's little. It's the pass manager info and the implication that there's a single latch.
Whatever you think is more appropriate.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74989/new/

https://reviews.llvm.org/D74989