[PATCH] D75090: [ORC] Align weak definition handling in JITDylib::defineMaterializing() and JITDylib::defineImpl()

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz created this revision.
sgraenitz added a reviewer: lhames.
Herald added subscribers: dexonsmith, steven_wu, hiraditya.
Herald added a project: LLVM.

In both functions handle all cases for symbol name collisions:

  (1) The incoming symbol is weak: reject the incoming symbol definition
  (2) The existing symbol is weak (and not materialized!): discard the existing symbol definition and insert the incoming one
  (3) Both symbol definitions are strong: DuplicateDefinition error 

This behavior would be very handy for ThinLtoJIT, because it (currently) uses weak definitions for fallback handlers. One example: let's say we have two modules, main.bc and rare.bc. The latter defines a function rarely() that is called from main.bc, so it will be resolved as a transitive dependency when linking main.bc even though it might never be called (or not even be reachable from our entry point!).

ThinLtoJIT will try to minimize the immediate/synchronous workload and bet on discovery to identify and emit all necessary code asynchronously. In many cases this may work, but it still needs a fallback in case rarely() gets called and discovery didn't manage to provide rare.bc in time. For this case it emits a synthetic call-through stub that does the work (load and emit the module). The symbol it defines for rarely() in the shadow dylib would then simply be weak, so that discovery can override it with the actual definition from rare.bc once it's ready.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75090

Files:
  llvm/examples/ThinLtoJIT/OnDemandLayer.cpp
  llvm/lib/ExecutionEngine/Orc/Core.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75090.246334.patch
Type: text/x-patch
Size: 7749 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200225/0f2818c4/attachment.bin>