[PATCH] D75033: [MachineVerifier] Doing ::calcRegsPassed over faster sets: ~15-20% faster MV

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin marked an inline comment as done.
rtereshin added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:2190
+public:
+  // Set-up the FILTERb. \pre Input register set \p RS must have no duplicates.
+  // Both virtual and physical registers are fine.
----------------
rtereshin wrote:
> rudkx wrote:
> > rtereshin wrote:
> > > rtereshin wrote:
> > > > rudkx wrote:
> > > > > FILTERb seems like a typo.
> > > > Not a typo, intended is `OUT_b`, as a subscript, for "block". FILTER is unique per BB.
> > > Does that clears the issue, or you'd rather prefer those subscripts dropped (I suppose everywhere then, not just on `FILTERb`)?
> > > 
> > > I don't have a preference, fine either way.
> > I hadn't noticed the comment before the `class` which is why it stuck out. I guess I'm not opposed to any particular convention as long as we're consistent here but the all-caps name with lower-case suffix did stick out.
> Yeah, I'm not very accustomed to trying to reproduce mathy notations in ASCII, I guess :)
> 
> Literally from wikipedia, for example:
> {F11415270}
> 
> Any particular style exists in LLVM's codebase for this kind of stuff? 
I talked to @qcolombet briefly about this, he says he's not aware about any particular style being preferred, and we converged on a little bit more LATeX'y take on this with everything lower case and underscores for subscripts: `out_b = in_b \ filter_b`. I'll go with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75033/new/

https://reviews.llvm.org/D75033