[PATCH] D75015: [ARM] Rewrite ARMAttributeParser

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D75015#1888821 <https://reviews.llvm.org/D75015#1888821>, @samparker wrote:

> This is a large change and converting to lower case is making really hard to discern what the functional changes are.


Pasted my reply in D74023 <https://reviews.llvm.org/D74023>.

> For existing code, there is objection that clean-ups can clutter up the history. There is a supportive group of people putting forward a migration plan. For *AttributeParser, I think it is a middle ground: the rewrite (refactoring) will touch nearly every line (we will also face a large function move ARMAttributeParser.cpp -> ELFAttributeParser.cpp). I am in the camp of "I don't want to unnecessarily break the style of surrounding code, but if it is new code, I want to just use the ideal style." So I went forward and fixed the variable Naming in D75015 <https://reviews.llvm.org/D75015>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75015/new/

https://reviews.llvm.org/D75015