[PATCH] D75032: [MachineVerifier] Doing ::calcRegsPassed in RPO: ~35% faster MV

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin marked 2 inline comments as done.
rtereshin added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:2133-2134
+  // to MBB mapping all at once with the same as alternatives' time complexity.
+  // Constant factor could be on a bigger side, but this map takes only ~0.5%
+  // of total machine verifier time, so I'm sure we're fine.
+  std::map<unsigned, const MachineBasicBlock *> RPOWorklist;
----------------
bogner wrote:
> Not sure it's worth explaining this tradeoff in a comment - the explanation above is good for what we're doing here and the commit message is pretty clear on why. Feel free to leave as is if you think it's valuable though.
Nah, I agree, trimming the comment (as further briefly discussed offline).

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75032/new/

https://reviews.llvm.org/D75032