[PATCH] D74599: llvm: Set WINVER, _WIN32_WINNT to 0x601 (Windows 7) for MinGW

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 12:29:15 PST 2020


mstorsjo added a subscriber: hans.
mstorsjo added a comment.

Ping, could someone with better insight in the CMake setup comment on whether this is the right spot to add a thing like this? I guess this would end up included when building the runtimes (both as part of the monorepo, and when building them standalone, if the llvm cmake files are available), but I think that would be fine for now.

If there's no other comments I guess I could approve and commit this soon.

@hans, are you ok with taking this to 10.x after it lands on master, to fix PR44907, or are we too close to release now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74599/new/

https://reviews.llvm.org/D74599





More information about the llvm-commits mailing list