[PATCH] D74991: Add methods to data extractor for extracting bytes and fixed length C strings.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/Support/DataExtractor.h:183
+  ///
+  /// \param[in,out] OffsetPtr
+  ///     A pointer to an offset within the data that will be advanced
----------------
Sorry for not asking this in the first iteration...

If we don't expect a nullptr to be passed in here, I think it would be better to use a reference?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74991/new/

https://reviews.llvm.org/D74991