[PATCH] D75062: [VectorCombine] make cost calc consistent for binops and cmps

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 10:21:20 PST 2020


lebedev.ri added a comment.

> We have the reverse transform with target hook in DAGCombiner already -- scalarizeExtractedBinop() -- so that provides a later opportunity to invert (potentially with a more accurate cost model).

I'm a little bit lost there.
Unless i'm not reading it right, even if the `TLI.shouldScalarizeBinop(Vec)` returns `true`,
the code only scalarizes if at least one of the vector operands is constant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75062/new/

https://reviews.llvm.org/D75062





More information about the llvm-commits mailing list