[PATCH] D73725: [DebugInfo] Avoid a quadratic-complexity corner case in LiveDebugValues

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: llvm/lib/CodeGen/LexicalScopes.cpp:302
+         CurMBBIt != EndBBIt; CurMBBIt++)
+      MBBs.insert(&*CurMBBIt);
 }
----------------
And now that it's simplified, this looks like we should use something like `std::copy()` instead of a loop :-)


================
Comment at: llvm/unittests/CodeGen/LexicalScopesTest.cpp:1
+//===- llvm/unittest/CodeGen/LexicalScopesTest.cpp --------------===//
+//
----------------
Super-nit: expand this to column 80?


================
Comment at: llvm/unittests/CodeGen/LexicalScopesTest.cpp:53
+  // Blocks that form part of the test environment.
+  MachineBasicBlock *MBB1, *MBB2, *MBB3, *MBB4;
+
----------------
Very cool! Should we fire up artist-mode and put the CFG into an ASCII art comment? (mostly joking)


================
Comment at: llvm/unittests/CodeGen/LexicalScopesTest.cpp:112
+
+    // Make some nested scopes
+    OutermostLoc = DebugLoc::get(3, 1, OurFunc);
----------------
.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73725/new/

https://reviews.llvm.org/D73725